search

arfedulov / semantic-ui-calendar-react

Datepicker react component based on semantic-ui-react components
https://arfedulov.github.io/semantic-ui-calendar-react/
MIT License
259 stars 92 forks source link

Component breaking because of moment version #199

Open gdelacruzfdez opened 4 years ago

gdelacruzfdez commented 4 years ago

Bug The new version of moment library breaks the component and the build. Other people have the same issue.

It is very simple to fix, we just need to fix the moment version to ~2.24.0.

WARNING in ./node_modules/semantic-ui-calendar-react/node_modules/moment/src/lib/locale/locales.js
Module not found: Error: Can't resolve './locale' in '/home/gdelacruz/CERN/remus-web/frontend/node_modules/semantic-ui-calendar-react/node_modules/moment/src/lib/locale'
 @ ./node_modules/semantic-ui-calendar-react/node_modules/moment/src/lib/locale/locales.js
 @ ./node_modules/semantic-ui-calendar-react/node_modules/moment/src/lib/locale/locale.js
 @ ./node_modules/semantic-ui-calendar-react/node_modules/moment/src/moment.js
 @ ./node_modules/semantic-ui-calendar-react/dist/commonjs/inputs/YearInput.js
 @ ./node_modules/semantic-ui-calendar-react/dist/commonjs/index.js
 @ ./src/components/MeteoDataExtraction/MeteoDataExtractionForm/index.jsx
 @ ./src/pages/MeteoDataExtractionPage/index.jsx
 @ ./src/pages/index.js
 @ ./src/nav/ContentContainer/index.jsx
 @ ./src/nav/index.jsx
 @ ./src/App.jsx
 @ ./src/index.jsx
 @ multi ./node_modules/error-overlay-webpack-plugin/lib/entry-basic.js ./node_modules/error-overlay-webpack-plugin/lib/entry-devserver.js? ./src/index.jsx

To Reproduce Just reinstalling node_modules and running your app it should break.

Pull request #200 fixes the issue

gdelacruzfdez commented 4 years ago

The issue has been fixed in moment library. Anyway, it may be a good idea to fix the version of moment to avoid that the same issue happens again.