argilla-io / argilla

Argilla is a collaboration tool for AI engineers and domain experts to build high-quality datasets
https://docs.argilla.io
Apache License 2.0
4.07k stars 382 forks source link

feat: change dataset publish validation to have at least one question (required or not) #5588

Closed jfcalvo closed 1 month ago

jfcalvo commented 1 month ago

Description

This PR includes changes aligning validations for publishing datasets so a dataset can be published with at least one question (being required or not). The same that we were doing before with fields.

Refs https://github.com/argilla-io/roadmap/issues/21

Type of change

How Has This Been Tested

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.20%. Comparing base (16cbc35) to head (6c478cc). Report is 42 commits behind head on feat/argilla-direct-feature-branch.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/argilla-direct-feature-branch #5588 +/- ## =================================================================== Coverage 91.20% 91.20% =================================================================== Files 145 145 Lines 6026 6026 =================================================================== Hits 5496 5496 Misses 530 530 ``` | [Flag](https://app.codecov.io/gh/argilla-io/argilla/pull/5588/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argilla-io) | Coverage Δ | | |---|---|---| | [argilla-server](https://app.codecov.io/gh/argilla-io/argilla/pull/5588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argilla-io) | `91.20% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=argilla-io#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

frascuchon commented 1 month ago

We can close this one @jfcalvo