ApplicationSet apparently doesn't respect `reposerver.enable.git.submodule: "false"`

[ftmiro]

Checklist:

• [x] I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• [x] I've included steps to reproduce the bug.
• [x] I've pasted the output of argocd version.

Describe the bug

I have an ApplicationSet failing to fetch files from a git generator due the repository used in the generator contain a gitmodule file referencing a repository using git (ssh) protocol, which I don't have an account registered in ArgoCD.

To Reproduce

1. Disable submodules:

apiVersion: v1
kind: ConfigMap
metadata:
  name: argocd-cmd-params-cm
data:
 ....
  reposerver.enable.git.submodule: "false"
 ....

Confirm that the argocd-repo-server pods have the following environment variable in it:

ARGOCD_GIT_MODULES_ENABLED=false

Create an applicationset with a Git generator that refers to a repository containing a submodule pointing to a private repository with no account registered in ArgoCD.

Expected behavior

No errors related to git submodules or attempts to fetch submodules

Version

v2.11.2+25f7504

Logs

failed to get params for second generator in the matrix generator: child generator returned an error on parameter generation: error generating params from git: error retrieving Git files: rpc error: code = Internal desc = unable to checkout git repo https://github.com/org/repo with revision 8293d861c1640ce3e4fdf4f9054ce491d73afed7 pattern values.yaml: failed to initialize repository resources: rpc error: code = Internal desc = Failed to checkout FETCH_HEAD: `git submodule update --init --recursive` failed exit status 1

[crenshaw-dev]

ApplicationSet controller requests to the repo-server override the repo-server's default submodule configuration. This allows people to enable or disable submodules only for AppSet controller requests.

To toggle the appset controller's submodule setting, use the following:

applicationsetcontroller.enable.git.submodule: "false"

[pazfelipe]

@crenshaw-dev , could you be more specific about the location that we should apply this configuration?

applicationsetcontroller.enable.git.submodule: "false"

[crenshaw-dev]

@pazfelipe set that value in argocd-cmd-params-cm and then restart the appset controller.