search

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18.05k stars 5.51k forks source link

feat: adopt delete app confirmation to new prompt util #20664

Closed pasha-codefresh closed 3 weeks ago

pasha-codefresh commented 3 weeks ago

Related to: https://github.com/argoproj/argo-cd/issues/19528

Here also was a bug related to deletion of multiple resources, it didnt because numOfApps was initialized incorrectly

  1. Cascade delete is false and no --yes flag ( which enables prompts )

Снимок экрана 2024-11-05 в 14 15 17

  1. Cascade delete is true and noPrompt is false Снимок экрана 2024-11-05 в 14 45 19
bunnyshell[bot] commented 3 weeks ago

:x: Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 25.58140% with 32 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@8cf990b). Learn more about missing BASE report. Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/app.go 0.00% 19 Missing :warning:
cmd/argocd/commands/utils/prompt.go 45.83% 13 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #20664 +/- ## ========================================= Coverage ? 55.10% ========================================= Files ? 324 Lines ? 55262 Branches ? 0 ========================================= Hits ? 30451 Misses ? 22196 Partials ? 2615 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.