argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18.05k stars 5.51k forks source link

fix: only check for source position when --show-params is set #20682

Closed gdsoumya closed 3 weeks ago

gdsoumya commented 3 weeks ago

Fixes https://github.com/argoproj/argo-cd/issues/20670

This PR ensures that app get works for multi source apps even when --source-position isn't provided. Source position check is only necessary if the user also sets --show-params

Checklist:

bunnyshell[bot] commented 3 weeks ago

:x: Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.18%. Comparing base (35b9158) to head (4f311e8). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/app.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #20682 +/- ## ========================================== - Coverage 55.20% 55.18% -0.02% ========================================== Files 324 324 Lines 55256 55257 +1 ========================================== - Hits 30505 30496 -9 + Misses 22143 22140 -3 - Partials 2608 2621 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gdsoumya commented 3 weeks ago

/cherry-pick release-2.13