argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18.05k stars 5.51k forks source link

fix(cli): Fix appset generate in --core mode #20717

Closed OpenGuidou closed 1 week ago

OpenGuidou commented 3 weeks ago

Fixes #20692

I'd like it to be cherry-picked to 2.13.

Checklist:

bunnyshell[bot] commented 3 weeks ago

:x: Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

speedfl commented 3 weeks ago

LGTM

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 55.16%. Comparing base (993d79c) to head (8de96ed). Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/headless/headless.go 0.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #20717 +/- ## ========================================== - Coverage 55.21% 55.16% -0.05% ========================================== Files 324 324 Lines 55256 55263 +7 ========================================== - Hits 30508 30485 -23 - Misses 22133 22160 +27 - Partials 2615 2618 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

OpenGuidou commented 1 week ago

/cherry-pick release-2.13