search

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18.04k stars 5.51k forks source link

Standardize the application-related log structured fields #20731

Open andrii-korotkov-verkada opened 2 weeks ago

andrii-korotkov-verkada commented 2 weeks ago

Summary

In some places like application controller file there's a standardization to specify application structured field value without a namespace, while also adding namespace as a separate field + a couple more fields https://github.com/argoproj/argo-cd/blob/5d0a3e6e9abd7e922e72e27c992ed0cdc0824f99/controller/appcontroller.go#L101-L108. However, it's not like that in all files, and some files still log the application field with prepended namespace and /. It'd be great to standardize this across the codebase.

Motivation

Easier and more consistent log analysis experience.

Proposal

Audit places which log or should application field, move the helper function to the common utils and use it in those places.

d-cryptic commented 2 weeks ago

Hi, I want to contribute on this issue. Can you assign this to me please?