argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18.04k stars 5.51k forks source link

chore: Better temp directory cleanup in TestGenerateManifestsHelmWithRefs_CachedNoLsRemote #20780

Open andrii-korotkov-verkada opened 2 weeks ago

andrii-korotkov-verkada commented 2 weeks ago

Helps with #20035

There are occasional failures due to unlinking .git file. An improvement can be made to set permissions on directories as files as much as we can instead of stopping completely on error.

Checklist:

bunnyshell[bot] commented 2 weeks ago

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.15%. Comparing base (b78f209) to head (4438287). Report is 21 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #20780 +/- ## ========================================== - Coverage 55.17% 55.15% -0.02% ========================================== Files 324 324 Lines 55259 55256 -3 ========================================== - Hits 30487 30475 -12 - Misses 22158 22165 +7 - Partials 2614 2616 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.