argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18.04k stars 5.51k forks source link

feat: Sync timeouts for applications (#6055) #20816

Open andrii-korotkov-verkada opened 1 week ago

andrii-korotkov-verkada commented 1 week ago

Helps with #6055

Introduces a controller-level configuration for terminating sync after timeout.

Checklist:

bunnyshell[bot] commented 1 week ago

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@6d8d32f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
controller/appcontroller.go 60.00% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #20816 +/- ## ========================================= Coverage ? 55.16% ========================================= Files ? 324 Lines ? 55268 Branches ? 0 ========================================= Hits ? 30486 Misses ? 22165 Partials ? 2617 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rumstead commented 1 week ago

Nice! Do you think we can add a few e2e tests?

andrii-korotkov-verkada commented 1 week ago

I have TestSyncTimeout, but can also add end-to-end if necessary. Though I'm not sure they'd add more value, since they'd be replicating the logic from TestSyncTimeout. What do you think?

rumstead commented 1 week ago

I have TestSyncTimeout, but can also add end-to-end if necessary. Though I'm not sure they'd add more value, since they'd be replicating the logic from TestSyncTimeout. What do you think?

I was thinking that deploying an application that will never leave progressing and being able to make sure it the sync status fails would be a good one to have. If you think the unit tests are solid, rock on!