Open andrii-korotkov-verkada opened 1 week ago
See: Environment Details | Pipeline Logs
Available commands (reply to this comment):
/bns:start
to start the environment /bns:deploy
to redeploy the environment /bns:delete
to remove the environment Attention: Patch coverage is 69.23077%
with 4 lines
in your changes missing coverage. Please review.
Please upload report for BASE (
master@6d8d32f
). Learn more about missing BASE report.
Files with missing lines | Patch % | Lines |
---|---|---|
controller/appcontroller.go | 60.00% | 3 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Nice! Do you think we can add a few e2e tests?
I have TestSyncTimeout
, but can also add end-to-end if necessary. Though I'm not sure they'd add more value, since they'd be replicating the logic from TestSyncTimeout
. What do you think?
I have
TestSyncTimeout
, but can also add end-to-end if necessary. Though I'm not sure they'd add more value, since they'd be replicating the logic fromTestSyncTimeout
. What do you think?
I was thinking that deploying an application that will never leave progressing and being able to make sure it the sync status fails would be a good one to have. If you think the unit tests are solid, rock on!
Helps with #6055
Introduces a controller-level configuration for terminating sync after timeout.
Checklist: