argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18.04k stars 5.51k forks source link

fix(app): Do not allow Argo-CD namespace access by default when app in any namespace restrictions exist #20827

Open OpenGuidou opened 1 week ago

OpenGuidou commented 1 week ago

Fix part of #20820.

With the current behavior it is not possible to restrict the usage of the Argo CD namespace when using the App in any namespace feature. This PR contains changes that should allow the current behavior when no restrictions are in place, and allow to blacklist the controller namespace if desired.

The new behavior should be quite sound but I can wrap it with a feature-flag if required.

I'd like this to be cherry-picked to 2.13 as well.

Checklist:

bunnyshell[bot] commented 1 week ago

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

OpenGuidou commented 1 week ago

Sure !