argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.66k stars 5.38k forks source link

Docs update required for Azure AD SAML Enterprise App Auth using Dex #8754

Open kmanchik opened 2 years ago

kmanchik commented 2 years ago

Summary

What change do you think needs making?

What is the issue?

<Attribute Name="http://schemas.microsoft.com/claims/groups.link">

<AttributeValue>

https://graph.windows.net/48d6943f-580e-40b1-a0e1-c07fa3707873/users/ba9b7081-e2a8-4427-9cdc-92afd7099833/getMemberObjects

</AttributeValue>

</Attribute>

Why the change is required?

Helpful documents:

Jellyfrog commented 2 years ago

If I make this change (from "All Groups") I just get the following error;

Failed to authenticate: no attribute with name "Group": [http://schemas.microsoft.com/identity/claims/tenantid http://schemas.microsoft.com/identity/claims/objectidentifier http://schemas.microsoft.com/identity/claims/displayname http://schemas.microsoft.com/identity/claims/identityprovider http://schemas.microsoft.com/claims/authnmethodsreferences http://schemas.xmlsoap.org/ws/2005/05/identity/claims/givenname http://schemas.xmlsoap.org/ws/2005/05/identity/claims/surname http://schemas.xmlsoap.org/ws/2005/05/identity/claims/emailaddress http://schemas.xmlsoap.org/ws/2005/05/identity/claims/name email]

Jellyfrog commented 2 years ago

...But It might be because we got the "free" Azure AD, that doesnt support groups in applications

JohnLBevan commented 11 months ago

...But It might be because we got the "free" Azure AD, that doesnt support groups in applications

What do your AAD App's SSO/SAML settings look like? Do you have user.groups mapped?

image

Also, how many AAD groups are you in? Documentation implies that this issue kicks in at 150 groups (if you're in AD-AAD Hybrid, not sure how the synced AD groups/any nesting there impacts this number).. But it looks like you can get a count by visiting Graph Explorer and running Groups > all groups I belong to (direct or indirect membership) with count (uri: https://graph.microsoft.com/v1.0/me/transitiveMemberOf/microsoft.graph.group?$count=true) then checking the count attribute.

andrewhibbert commented 7 months ago

I have also needed to change the group claim from "All Groups" to "Groups assigned to the application" to get this to work