search

argoproj / argo-rollouts

Progressive Delivery for Kubernetes
https://argo-rollouts.readthedocs.io/
Apache License 2.0
2.67k stars 839 forks source link

Support Knative Services for Rollouts #2186

Open salaboy opened 2 years ago

salaboy commented 2 years ago

Summary

Related to: https://github.com/knative/serving/issues/13024 Supporting Knative Services if Knative is installed seems to be something both communities want to see happening. I wonder how I can facilitate the integration from the Knative side to at least have a PoC that we can use to validate if a fully-fledged feature is needed. Is the Argo Rollouts community aware of any experiments around this topic?

What change needs making?

The Argo Rollouts controller needs to be aware of Knative Services and maybe allow rollouts to reference Services instead of fully defining the podSpecTemplate.

I wonder what the maintainers think about a separate rollouts controller to deal with Knative or just an extension to the one that already exists? The idea here is not to duplicate the entire rollouts functionality in the Knative community, I believe that duplication of all the amazing work that has been done in the Argo Rollouts community can be extended instead of promoting duplication.

Use Cases

When would you use this?

If Knative Serving is available on the Cluster, Argo Rollouts can use the Knative Serving traffic management capabilities instead of relying on a Service Mesh.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

spaghettifunk commented 2 years ago

Related discussion: https://github.com/argoproj/argo-rollouts/discussions/2133

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity.

dprotaso commented 1 year ago

bump

JhoLee commented 1 year ago

Any updates?

salaboy commented 1 year ago

@JhoLee unfortunately not, I would love to participate in a proposal definition, but we will need guidance from the team and also someone willing to get their hands dirty writing an initial PoC.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity.

todaywasawesome commented 1 year ago

Additional discussion: https://github.com/argoproj/argo-rollouts/discussions/2133

zachaller commented 1 year ago

https://cloud-native.slack.com/archives/C01U781DW2E/p1689755530884959?thread_ts=1689755530.884959&cid=C01U781DW2E

github-actions[bot] commented 11 months ago

This issue is stale because it has been open 60 days with no activity.

marcindulak commented 6 months ago

👀