argoproj / argo-workflows

Workflow Engine for Kubernetes

https://argo-workflows.readthedocs.io/

Apache License 2.0

15.12k stars 3.21k forks source link

More efficient SaveResourceParameters #5658

Open book987 opened 3 years ago

book987 commented 3 years ago

Summary

Currently argo call kubectl get for each output parameters in resource template. It can decrease to 1 time kubectl get call and len(outputs.parameters) times processing with same data, saving network traffic, and also preventing data inconsistency if something happen to the resource between the loop.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

terrytangyuan commented 3 years ago

Good idea. It would be even better if we could switch to use k8s SDK for this as well instead of kubectl. Would you like to submit a PR for this?

book987 commented 3 years ago

Good idea. It would be even better if we could switch to use k8s SDK for this as well instead of kubectl. Would you like to submit a PR for this?

yeah, I'd like to.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

terrytangyuan commented 2 years ago

kubectl removal: https://github.com/argoproj/argo-workflows/issues/7797