argoproj / argocd-example-apps

Example Apps to Demonstrate Argo CD
1.6k stars 7.26k forks source link

Getting Started deployment is broken (missing redis when using the guestbook) #126

Open fungiboletus opened 2 years ago

fungiboletus commented 2 years ago

Hi,

I'm following the "Getting Started" ArgoCD documentation. I successfully deployed the guestbook, but you may want to know that the deployment is broken. Redis is missing.

I get the following PHP exception when I post a message:

<br />
<b>Fatal error</b>:  Uncaught exception 'Predis\Connection\ConnectionException' with message 'php_network_getaddresses: getaddrinfo failed: Name or service not known [tcp://redis:6379]' in /usr/local/lib/php/Predis/Connection/AbstractConnection.php:155
Stack trace:
#0 /usr/local/lib/php/Predis/Connection/StreamConnection.php(128): Predis\Connection\AbstractConnection-&gt;onConnectionError('php_network_get...', 0)
#1 /usr/local/lib/php/Predis/Connection/StreamConnection.php(178): Predis\Connection\StreamConnection-&gt;createStreamSocket(Object(Predis\Connection\Parameters), 'tcp://redis:637...', 4)
#2 /usr/local/lib/php/Predis/Connection/StreamConnection.php(100): Predis\Connection\StreamConnection-&gt;tcpStreamInitializer(Object(Predis\Connection\Parameters))
#3 /usr/local/lib/php/Predis/Connection/AbstractConnection.php(81): Predis\Connection\StreamConnection-&gt;createResource()
#4 /usr/local/lib/php/Predis/Connection/StreamConnection.php(258): Predis\Connection\AbstractConnection-&gt;connect()
#5 /usr/local/lib/php/Predis/Connection/Abstract in <b>/usr/local/lib/php/Predis/Connection/AbstractConnection.php</b> on line <b>155</b><br />

It's not critical to understand ArgoCD, but I think it would look better if the first deployment you do using ArgoCD works 🙂

danielhelfand commented 2 years ago

Thanks for opening this @fungiboletus!

Agreed that the sample app should be connected to redis and work as expected. We could use the kubernetes/example manifest shown here. Unfortunately, the app is broken as I discovered/mentioned in this issue.

We could maybe think about hosting our own frontend image to help resolve this and get the example fixed sooner if there isn't a new image made available soon.

jamesdesmond commented 2 years ago

I also ran into this issue, is there another example here that would work?

danielhelfand commented 2 years ago

@jamesdesmond If you are looking for a working guestbook app synced by Argo CD, you could use the following repo/commands:

argocd app create guestbook --repo https://github.com/danielhelfand/examples --path guestbook/all-in-one --directory-include guestbook-all-in-one.yaml --dest-name in-cluster --dest-namespace default

argo app sync guestbook

It's my own personal repository with my own guestbook image on dockerhub. In this repository, the app deployed is just the UI at the moment.

gpltaylor commented 1 year ago

Really! This makes me worry about using this product within a commercial production environment. The Demo is broken and doesn't run?? If this CD tool is so good, how can it not also deploy the Redis Service to allow the demo to run..

This is scary that this is over a year old and oneone has reviewed this?

crenshaw-dev commented 5 months ago

For some reason this post became a honeypot for spam. Apologies for all the delete messages.

crenshaw-dev commented 5 months ago

This thread became just spam bots, so locking for now. Feel free to open another issue with the same description.