search

argumentcomputer / bellpepper-gadgets

A library of gadgets compatible with bellpepper and bellperson (contact: @huitseeker)
Apache License 2.0
17 stars 13 forks source link

Adding SHA1 gadget #7

Closed avras closed 11 months ago

avras commented 1 year ago

A second attempt at the SHA1 gadget using a simpler OR gate. See previous attempt at https://github.com/lurk-lab/bellpepper-gadgets/pull/6

avras commented 1 year ago

I will make changes to this gadget to use the in-built Boolean::or once https://github.com/lurk-lab/bellpepper/pull/28 gets merged. We can hold this PR until then.

huitseeker commented 1 year ago

For development purposes, you can use a dependency override to test the De Morgan OR gadget now merged in the master branch of bellpepper, before the upcoming release.

huitseeker commented 12 months ago

Bellpepper 0.3.0 is released with the or gadget!

avras commented 12 months ago

Thanks @huitseeker for the heads up. It feels good to contribute to bellpepper. I will get the SHA1 PR done soon.

adr1anh commented 11 months ago

Thanks for replying to the comments, happy to review the updates!

avras commented 11 months ago

Hey @adr1anh, please check if I have addressed all your suggestions. I renamed some variables to better match the spec.

No nitpick is too small. Send them all.