search

arichornlover / uYouEnhanced

uYouEnhanced (by @arichornlover) is an expanded version of uYou+ (made by @qnblackcat) with additional features and mainly made for non jailbroken users!
https://github.com/arichornlover/YouTubeRebornPlus/
2.2k stars 3k forks source link

[Bug] Disable Pinch to Zoom is interfering with DontEatMyContent #206

Open Blarnix opened 10 months ago

Blarnix commented 10 months ago

Is there an existing issue for this?

Have you read the FAQ?

Device info

Describe the bug

Hi, I'm having some issues in regards to DontEatMyContent and Disable Pinch to Zoom being enabled at the same time. Having both of these running at once leads to this strange behavior: https://user-images.githubusercontent.com/61402697/282995841-e3a19b8e-5dee-4ce9-bc5e-4186752f6878.MOV

I'm not sure if it's on one side or the other, so I reported the issue to both repos. This has been going on for quite a while, so it's not really anything new. Hopefully it's an easy fix. Thanks.

Steps to reproduce the issue

  1. Open uYouPlus+
  2. Enable DontEatMyContent and "Disable Pinch to Zoom"
  3. Restart uYouPlus+
  4. Open a video with a wide aspect ratio (I suggest LTT or MKBHD)
  5. Try to pinch to enter full screen or pinch out.

Crash log (if the app crashes)

No response

Are you using the newest version of uYouPlus? If not, why?

✅ Yes, I'm using the latest version of uYouPlus right now

Does the issue happen with the official YouTube from AppStore?

❌ No, I can't reproduce this issue in the official YouTube from AppStore

Additional context

No response

Blarnix commented 10 months ago

Seems that the issue will be fixed once a new .deb is released for DontEatMyContent, according to therealFoxter.

Thanks! I think they nuked the pinch recognizer which I'm using to deactivate the constraints when you pinch to zoom. a08f9d9 should fix this.

Originally posted by @therealFoxster in https://github.com/therealFoxster/DontEatMyContent/issues/15#issuecomment-1811770883

arichornlover commented 10 months ago

This should work with the latest release of uYouPlusExtra aswell.

Blarnix commented 10 months ago

Unfortunately, the issue is still present.

arichornlover commented 10 months ago

That’s odd.. it’s using DontEatMyContent v1.0.12?

Blarnix commented 10 months ago

That’s odd.. it’s using DontEatMyContent v1.0.12?

I think so? I'm not sure how to check the specific version of DontEatMyContent, but I am using UYouPlus+ 18.45.2-3.0.1 that was just released.