arichornlover / uYouEnhanced

uYouEnhanced (by @arichornlover) is an expanded version of uYou+ (made by @qnblackcat) with additional features and mainly made for non jailbroken users!
https://github.com/arichornlover/YouTubeRebornPlus/
2.34k stars 3.63k forks source link

Wrong video in yt shorts? #778

Open Caitlynmcc234 opened 3 weeks ago

Caitlynmcc234 commented 3 weeks ago

Is there an existing issue for this?

Have you read the Wiki?

iOS/iPadOS version

iOS 18.1 beta 4

Device model

iPhone 11

Sideload method

SideStore w/ SparseBox 3 app bypass

Tweak version

19.42.1-3.0.4

Do you use YouTube Premium?

❌ No, I don't use YouTube Premium

Describe the bug

When scrolling, the titles/comments get mismatched from the video IMG_0183

Steps to reproduce the issue

  1. Open yt shorts
  2. Scroll

Crash log (if the app crashes)

No response

Are you using the newest version of uYouEnhanced?

✅ Yes, I'm using the latest version

Does the issue happen with the official YouTube from AppStore?

❌ No, I can't reproduce this issue in the official YouTube from AppStore

Select the configuration used for building or obtaining the uYouEnhanced ipa. (Optional)

buildapp.yml (GitHub Actions — build method as suggested by Wiki - Building)

Additional context

The 3 app bypass should not be affecting the apps

jianmingyong commented 3 weeks ago

The server side probably changed some stuff causing the app to glitch out. This exists in the older version too. While it doesn’t really affect playability, the title of the video is not the same as what is shown.

ebenhaizer commented 3 weeks ago

i have this same problem on 19.42.1-3.0.4

the problem is because it shows ads while it shows the title and channel that the next video has

example: when you first click your first yt shorts video it still shows the correct title but after a few scroll and theres ads (idk why it shows ads) it shows the title and the channel that the next video has thats where the problem start after that all of the videos have the wrong title and channel.

sorry for bad english

Loneshade commented 3 weeks ago

i have this same problem on 19.42.1-3.0.4

the problem is because it shows ads while it shows the title and channel that the next video has

example: when you first click your first yt shorts video it still shows the correct title but after a few scroll and theres ads (idk why it shows ads) it shows the title and the channel that the next video has thats where the problem start after that all of the videos have the wrong title and channel.

sorry for bad english

This is what happens. Even when ads are set to be blocked, they will appear in the YouTube short this is where the video titles, like and comments get messed up. As they are loading the UI part for the video after the advert. Which in turn ends up having a UI with a title, likes and comments for a video which could be 4 or 5 videos a head, sometimes further depending on how long you are scrolling for.

ebenhaizer commented 3 weeks ago

i have this same problem on 19.42.1-3.0.4 the problem is because it shows ads while it shows the title and channel that the next video has example: when you first click your first yt shorts video it still shows the correct title but after a few scroll and theres ads (idk why it shows ads) it shows the title and the channel that the next video has thats where the problem start after that all of the videos have the wrong title and channel. sorry for bad english

This is what happens. Even when ads are set to be blocked, they will appear in the YouTube short this is where the video titles, like and comments get messed up. As they are loading the UI part for the video after the advert. Which in turn ends up having a UI with a title, likes and comments for a video which could be 4 or 5 videos a head, sometimes further depending on how long you are scrolling for.

Seems fixed now for me on 19.43.2 - 3.0.4 Been using it for hours & no prob so far

Edit: yep not fixed, still has ads showing that makes the title mislead the video

Egaliterrier commented 3 weeks ago

i have this same problem on 19.42.1-3.0.4 the problem is because it shows ads while it shows the title and channel that the next video has example: when you first click your first yt shorts video it still shows the correct title but after a few scroll and theres ads (idk why it shows ads) it shows the title and the channel that the next video has thats where the problem start after that all of the videos have the wrong title and channel. sorry for bad english

This is what happens. Even when ads are set to be blocked, they will appear in the YouTube short this is where the video titles, like and comments get messed up. As they are loading the UI part for the video after the advert. Which in turn ends up having a UI with a title, likes and comments for a video which could be 4 or 5 videos a head, sometimes further depending on how long you are scrolling for.

Seems fixed now for me on 19.43.2 - 3.0.4 Been using it for hours & no prob so far

Not fixed here, using same yt version and an ipa built from the latest commit of this repo.

jianmingyong commented 2 weeks ago

Try doing this: IMG_0204

ebenhaizer commented 2 weeks ago

Try doing this: IMG_0204

Tried this, didnt fix the issue

TheTrueShadow commented 2 weeks ago

I have am pretty sure this is a stock YouTube issue because I've seen this happen on android YouTube too but I could be wrong.

Egaliterrier commented 2 weeks ago

I have am pretty sure this is a stock YouTube issue because I've seen this happen on android YouTube too but I could be wrong.

I mean, it’s an issue with a new ad implementation in shorts that isn’t properly blocked by the tweaks yet, don’t see how this would happen on the stock app. Also, if the yt devs missed that big of an issue, we would’ve seen a fix pushed by them by now. Wanted to test it, just without the ad-blocking tweaks enabled, but that just revealed a whole other, probably more severe issue - @arichornlover, disabling ad-blocking in uYouEnhanced and uYou causes a crash when watching shorts and swiping to the third (where the ad is supposed to be).

jianmingyong commented 2 weeks ago

It seems like everyone had a different experience when trying to get around it. For me, version spoofer completely fixed the bug as there is no more ads that cause the misalignment.

Probably also due to the YT binary that is being patched on top of as I often use the latest one than using altstore/trollstore ipa.

Egaliterrier commented 2 weeks ago

It seems like everyone had a different experience when trying to get around it. For me, version spoofer completely fixed the bug as there is no more ads that cause the misalignment.

Probably also due to the YT binary that is being patched on top of as I often use the latest one than using altstore/trollstore ipa.

True, thats a good point, would be helpful to know what version of YouTube everyone experiencing this issue is using. Unless completely broken, I keep my build updated with the newest versions of everything, so right now I am running the latest commit of uYouEnhanced on 19.43.2.

EDIT: Updating to 19.44.4 now.

Unsurprisingly, the issue is also present in 19.44.4. uYouEnhanced setting titles are also bugged, some issue with the correct strings not being applied, it seems. 0448C47D-EFCC-4508-9CBB-26C953C1F07F

arichornlover commented 2 weeks ago

It seems like everyone had a different experience when trying to get around it. For me, version spoofer completely fixed the bug as there is no more ads that cause the misalignment. Probably also due to the YT binary that is being patched on top of as I often use the latest one than using altstore/trollstore ipa.

True, thats a good point, would be helpful to know what version of YouTube everyone experiencing this issue is using. Unless completely broken, I keep my build updated with the newest versions of everything, so right now I am running the latest commit of uYouEnhanced on 19.43.2.

EDIT: Updating to 19.44.4 now.

Unsurprisingly, the issue is also present in 19.44.4. uYouEnhanced setting titles are also bugged, some issue with the correct strings not being applied, it seems. 0448C47D-EFCC-4508-9CBB-26C953C1F07F

One of the TITLES were duplicated in uYouEnhanced by mistake. I have fixed it recently in https://github.com/arichornlover/uYouEnhanced/commit/1b0cf16ccfcdafe92c4f45410067bab7b9284b0f

Egaliterrier commented 2 weeks ago

One the of TITLES were duplicated in uYouEnhanced by mistake. I have fixed it recently in 1b0cf16

Thanks, that fixed the titles. Another small issue is the setting to hide the sponsorblock button not working. Btw, Youtube-X has a minor update, blocking another type of ad. Doesn’t solve the shorts bug this issue is about though, merged the changes to test that. I think some other tweaks and things you have forked also got smaller updates aswell, YouTubeHeaders iirc. Thanks for your work, couldn’t live without it.

arichornlover commented 2 weeks ago

One the of TITLES were duplicated in uYouEnhanced by mistake. I have fixed it recently in 1b0cf16

Thanks, that fixed the titles. Another small issue is the setting to hide the sponsorblock button not working. Btw, Youtube-X has a minor update, blocking another type of ad. Doesn’t solve the shorts bug this issue is about though, merged the changes to test that. I think some other tweaks and things you have forked also got smaller updates aswell, YouTubeHeaders iirc. Thanks for your work, couldn’t live without it.

Fixed the hide iSponsorBlock Button option! https://github.com/arichornlover/uYouEnhanced/commit/8d5b63e77e8ab51de8d9429f134be651aad4e9cb

Egaliterrier commented 2 weeks ago

Fixed the hide iSponsorBlock Button option! 8d5b63e

That was fast! Though now compiling is broken:/

arichornlover commented 2 weeks ago

Fixed the hide iSponsorBlock Button option! 8d5b63e

That was fast! Though now compiling is broken:/

Sorry about that. One of the submodules I updated broke when I changed something. But compiler has been tested and works without a problem now.

yodaluca23 commented 2 weeks ago

I think this is a server side change because I haven't updated it in a while. I'm on 19.41.3. and it just started happening to me literally this morning...

Egaliterrier commented 2 weeks ago

I think this is a server side change because I haven't updated it in a while. I'm on 19.41.3. and it just started happening to me literally this morning...

Yeah I’m pretty sure that’s the case. Like all the other ads so far though, this is probably blockable client-side. Hopefully @poomsmart can just add them to Youtube-X without much trouble.

TheConfax commented 1 week ago

Hi guys, iI don't think it's server side, I reverted to 19.21.2 + 3.0.4 (from the uyouplus website) and the problem is gone.

Let me know if this is of any help @arichornlover

yodaluca23 commented 1 week ago

Hi guys, iI don't think it's server side, I reverted to 19.21.2 + 3.0.4 (from the uyouplus website) and the problem is gone.

There is no uYouPlus website, besides the GitHub page, and the Alt Store repo, whatever you downloaded is not official, and may have malware. Also, it may be A/B flags that we just have to figure out as a bandage patch...

TheConfax commented 1 week ago

Hi guys, iI don't think it's server side, I reverted to 19.21.2 + 3.0.4 (from the uyouplus website) and the problem is gone.

There is no uYouPlus website, besides the GitHub page, and the Alt Store repo, whatever you downloaded is not official, and may have malware. Also, it may be A/B flags that we just have to figure out as a bandage patch...

It's not malware, it's the website of the original uYou+ dev, supporting uYou Enhanced: https://uyouplus.com/uyou-enhanced/ I'm looking into A/B flags as well, but rolling back seems the easiest solution if you want to try.

yodaluca23 commented 1 week ago

It's not malware, it's the website of the original uYou+ dev, supporting uYou Enhanced: https://uyouplus.com/uyou-enhanced/

This website is made by an unknown user, and could potentially have malware, IT IS NOT official.

yodaluca23 commented 1 week ago

It's not malware, it's the website of the original uYou+ dev, supporting uYou Enhanced: uyouplus.com/uyou-enhanced

This website is made by an unknown user, and could potentially have malware, IT IS NOT official.

See https://github.com/arichornlover/uYouEnhanced/discussions/2#discussioncomment-9105979

TheConfax commented 1 week ago

It's not malware, it's the website of the original uYou+ dev, supporting uYou Enhanced: uyouplus.com/uyou-enhanced

This website is made by an unknown user, and could potentially have malware, IT IS NOT official.

See #2 (comment)

Nice to know, regardless of the website officialness 19.21.2 does not have this issue. If anyone wanna try the rollback and confirm this might not be server-side.

arichornlover commented 1 week ago

Hi guys, iI don't think it's server side, I reverted to 19.21.2 + 3.0.4 (from the uyouplus website) and the problem is gone.

Let me know if this is of any help @arichornlover

First don’t install IPAs from random sites. (Includes the uyouplus website.)

Second, the shorts issue has gotten bad in newer versions of YouTube, I can’t tell if it’s the code from uYouEnhanced or uYou causing it to happen. I’ll see if it can be resolved.

yodaluca23 commented 1 week ago

Second, the shorts issue has gotten bad in newer versions of YouTube,

Indeed, it has, it's very annoying

I can’t tell if it’s the code from uYouEnhanced or uYou causing it to happen. I’ll see if it can be resolved.

Thank you so much! 😄

TheConfax commented 1 week ago

First don’t install IPAs from random sites. (Includes the uyouplus website.)

Thanks for the cybersecurity lessons but I do know how to do my due diligence :) IPA is pulled from a collection on Internet Archive, on which by the way your account name is appearing. You may want to proactively look into that due to DMCA. https://archive.org/details/YouTubeRebornPlus_19.10.5-4.2.6

Side note, I have been using that IPA for months and nothing suspicious ever happened. Source was never the point, one could just build that version combo (incidentally it is the last public one) and confirm there are no issues.

Second, the shorts issue has gotten bad in newer versions of YouTube, I can’t tell if it’s the code from uYouEnhanced or uYou causing it to happen. I’ll see if it can be resolved.

Thanks!

aricloverALT commented 1 week ago

I did a test. I disabled all of the Shorts-related Code to see if it fixes the problem. https://github.com/arichornlover/uYouEnhanced/commit/e15f42e37d375b6076cdcdf5cc2233ccafeb8834

edit: I undid the changes due to a YouTube-X update.

TheNightRider12 commented 1 week ago

The issue with shorts showing incorrectly seems to be fixed. At least on my end. However, I still am seeing ads in the feed.

yodaluca23 commented 1 week ago

The issue with shorts showing incorrectly seems to be fixed. At least on my end. However, I still am seeing ads in the feed.

Well yea, it removed all the shorts code, including adblocking. @arichornlover How hard would it be to completely rewrite shorts adblocking? Or to fix it?

voxpop9 commented 1 week ago

Just wanted to add, it may be the youtube backend because i remember the issue suddenly happening one day, and i did not update before it happened.

Egaliterrier commented 1 week ago

@aricloverALT https://github.com/PoomSmart/YouTube-X/commit/633b29abc2ed452a8b39248a28b1f2ebb6579233 new yt-x commit, will hopefully properly block shorts ads.

TheConfax commented 6 days ago

@aricloverALT PoomSmart/YouTube-X@633b29a new yt-x commit, will hopefully properly block shorts ads.

This does not solve the problem for me, ads are still showing even with the latest commits. (19.21.2 still works fine)

Egaliterrier commented 6 days ago

@aricloverALT PoomSmart/YouTube-X@633b29a new yt-x commit, will hopefully properly block shorts ads.

This does not solve the problem for me, ads are still showing even with the latest commits. (19.21.2 still works fine)

I don’t see the latest yt-x commit merged on your fork, so I think you might have just misunderstood which commit/repo I was talking about. I was referencing the latest commit to the youtube-x repo, not the latest commit to this repo. The most recent changes to yt-x have not yet been merged into this repo. All the issues are fixed for me by merging those changes, including ad-blocking. Try this pr: https://github.com/arichornlover/uYouEnhanced/pull/793

TheConfax commented 5 days ago

Hi @Egaliterrier, thanks for checking my fork, my bad.

I see now #793 as merged, updated fork with current, but I still see ads on shorts (shorts metadata is now correct though)

Egaliterrier commented 4 days ago

Hi @Egaliterrier, thanks for checking my fork, my bad.

I see now #793 as merged, updated fork with current, but I still see ads on shorts (shorts metadata is now correct though)

That’s weird, it should definitely be working. I assume you’ve restarted the app after the first launch, right? Almost no tweaks are applied on the first launch, at least for me. Are you using the default settings it installs with? Did you install on top of an already installed version of YouTube? I want to try and test your exact setup.

TheConfax commented 1 day ago

That’s weird, it should definitely be working. I assume you’ve restarted the app after the first launch, right? Almost no tweaks are applied on the first launch, at least for me.

Did not know that, yes it is now running correctly so I guess it needed a restart.

Did you install on top of an already installed version of YouTube? I want to try and test your exact setup.

With Sideloadly i cannot reinstall on top of the old YouTube (modded) anymore, it gives an error, i need to delete the app and install, plus it takes significantly longer than the older 19.21.2 + 3.0.4

Egaliterrier commented 12 hours ago

That’s weird, it should definitely be working. I assume you’ve restarted the app after the first launch, right? Almost no tweaks are applied on the first launch, at least for me.

Did not know that, yes it is now running correctly so I guess it needed a restart.

Did you install on top of an already installed version of YouTube? I want to try and test your exact setup.

With Sideloadly i cannot reinstall on top of the old YouTube (modded) anymore, it gives an error, i need to delete the app and install, plus it takes significantly longer than the older 19.21.2 + 3.0.4

Alright cool you got it solved. In general, I would advise to never update tweaked apps by installing on top of an existing version, there are so many things that can go wrong and cause issues; leftover files/tweaks that aren’t present in the version you overwrite it with, renamed files or folders, config incompatibilities. It will inevitably lead to issues or crashes. I’m willing to bet it is the cause of a bunch of the errors users post about here, heck I once reported an issue that was only caused by me not uninstalling first. The extra two minutes it takes to uninstall first and re-setup your usual settings on a clean, fresh install is worth it.