aristanetworks / avd

Arista Validated Designs
https://avd.arista.com
Apache License 2.0
302 stars 220 forks source link

Bug(eos_cli_config_gen): adjust generation of interface profile output #3285

Open RyanM-Arista opened 1 year ago

RyanM-Arista commented 1 year ago

Issue Summary

On devices with large number of ports with interface profiles, i.e. CCS-720XP-96ZC2, validate and compare times out on occasion and CVP throws an error. With discussion from TAC it was advised to adjust the location of the interface profile configuration as per the CV-Tips below to speed up the parsing of configurations with interface profiles.

https://www.arista.com/ko/cg-cv/cv-tips-for-applying-profiles-to-the-interfaces

Running AVD 3.8.7

Which component(s) of AVD impacted

eos_cli_config_gen

How do you run AVD ?

Ansible CLI (with virtual-env or native python)

Steps to reproduce

Supply a configlet to CVP with a large interface profile applied (ie dot1x profile with 7 separate commands) and apply this to 80+ interfaces, there is a high likelihood that this would time out on CVP when doing a validate + compare task. Configlet size is ~2200 lines of config.

Relevant log output

Error will be seen on CVP side.  CVP will throw an error and validate + compare task will fail.

Contributing Guide

carlbuchmann commented 1 year ago

@RyanM-Arista - thanks for submitting this issue.

So the recommendation would be to move the interface profile configuration template after the interface configuration template, in order to avoid this issue.

pvinci-arista commented 1 year ago

QQ: How is this a bug in AVD?

AVD supports this requirement today by moving the profile commands to eos_cli, which is rendered last, does it not?

ClausHolbechArista commented 1 year ago

Not sure this is really a bug in AVD as such, but more an optimization we can implement. Downside is that the produced config will not follow the order of EOS "show run" which we try to (I know we are still far from that target). BTW how are EOS-driven interface profiles useful when using AVD?

github-actions[bot] commented 10 months ago

This issue is stale because it has been open 90 days with no activity. The issue will be reviewed by a maintainer and may be closed