Closed wwade closed 4 years ago
Looks good, with a few comments. There are two things I'd also like you to add:
Could you add an entry in bst.1.scd documenting the new --limit- flags? Will do.
I'd like the rlimit implementation to be complete -- let's add support for all RLIMIT_* values. Prefer to do that in a follow up of some kind.
To give the user more control over the bst process, add three new options for runing
setrlimit
before exec.Each option requires an argument which is parsed as a colon-separated tuple of hard, soft resource limits. Each of hard and soft limits are optional, and when one is not specified, it will use the current value. The only exception is for the special value ":" which will use the current hard limit, and set the soft limit to the hard limit value.
Added test cases to bst.t and also added a unit test for the parsing code.
Usage strings: