search

aristanetworks / bst

A one-stop shop for process isolation
MIT License
99 stars 9 forks source link

Bug fix along with NULL and '\0' corrections #45

Closed jon-stumpf closed 3 years ago

jon-stumpf commented 3 years ago

The first commit fixes a bug in cleanpath.c where ".." path entries are not properly detected and, therefore, not collapsed. I suspect the paths continue to be usable by the program even if they are not ideal which explains why it has not been detected previously.

The second commit adds proper checks for NULL and '\0', replacing code that simply checks or assume these values are zero. This is hygiene and not any change in functionality. I made the edits simply because I was there, reviewing the code.

Snaipe commented 3 years ago

Looks good. I'll just squash the last commit into a0caede, too, since it doesn't need to exist by itself.

Snaipe commented 3 years ago

Rebased and merged as 7b368c1e0bc06d3ad0650be3393de117b42eaef1