search

aristanetworks / bst

A one-stop shop for process isolation
MIT License
99 stars 9 forks source link

build: restrict building bst for only linux platforms #58

Closed ani-sinha closed 3 years ago

ani-sinha commented 3 years ago

Currently bst cannot build or run on platforms other than linux. Headers like prctl.h, linux/capability.h etc are only available on Linux and not on other platforms. Hence, the meson build process should check the target platform (the platform for which the binary is being built) and bail out for non-supported platforms. For example, when trying to build bst on my Mac's darwin platform, I get the following descriptive error with this change:

Running test binary command: /Users/ani/workspace/bst/build/meson-private/sanitycheckc.exe C compiler for the build machine: cc (clang 12.0.5 "Apple clang version 12.0.5 (clang-1205.0.22.11)") C linker for the build machine: cc ld64 650.9 Build machine cpu family: x86_64 Build machine cpu: x86_64 Host machine cpu family: x86_64 Host machine cpu: x86_64 Target machine cpu family: x86_64 Target machine cpu: x86_64 Program sh found: YES (/bin/sh) Program git found: YES (/usr/bin/git) Program scdoc found: NO

meson.build:19:1: ERROR: Problem encountered: bst is not supported on darwin platform.

Signed-off-by: Ani Sinha ani@anisinha.ca

ani-sinha commented 3 years ago

Ping

Snaipe commented 3 years ago

LGTM, thanks for the change!