search

aristanetworks / goarista

Fairly general building blocks used in Arista Go code and open-sourced for the benefit of all.
Apache License 2.0
206 stars 66 forks source link

fix go1.12 #49

Closed rski closed 4 years ago

rski commented 4 years ago

pinky promise this is it.

Here's the problem; go1.13 has GOSUMDB and GOPROXY set up. Using go1.13, tjfoc/gmsm@v1.3.0 was downloaded from the proxy. go1.13 verified the thing it downloaded matched the checksum from GOSUMDB, wrote the checksum in sum.go, and went about its way.

Now, telling go1.12 to download the modules fails on the checksum of the above package. The issue being that for some reason, downloading gmsm from github, its checksum is different from what GOSUMDB has. And why does go1.12 not use proxy.golang.org? Because GOPROXY is not set in that version of go. Setting GOPROXY makes go1.12 download the right version of gmsm and this all goes away.

codecov-io commented 4 years ago

Codecov Report

Merging #49 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   76.27%   76.27%           
=======================================
  Files          14       14           
  Lines        1273     1273           
=======================================
  Hits          971      971           
  Misses        260      260           
  Partials       42       42

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0dc956a...d219b6e. Read the comment docs.