arkivverket / noark5-tjenestegrensesnitt-standard

6 stars 11 forks source link

Avskrivning#referanseAvskrivesAvJournalpost is a *-to-many relation in Noark 5.5 #281

Closed ivaylomitrev closed 1 year ago

ivaylomitrev commented 1 year ago

       Prosjekt  NOARK 5 Tjenestegresesnitt
       Kategori  Noark 5.5.0 TG versjon 1.0
    Alvorlighet  kommentar / protest
   Meldingstype  utelatt / trenger klargjøring
Brukerreferanse  user@example.com
    Dokumentdel  Chapter#7 (Avskrivning)

Beskrivelse

Avskrivning#referanseAvskrivesAvJournalpost (M215) is defined as a *-to-many relation in the Noark 5 standard whereas the specification defines a single (non-array) field for it. This makes it difficult to map to existing systems and might lead to data loss.

Ønsket endring

Avskrivning#referanseAvskrivesAvJournalpost to be converted to a list of Journalpost entities or to an array of UUIDs.

petterreinholdtsen commented 1 year ago

[ivaylomitrev]

Avskrivning#referanseAvskrivesAvJournalpost is defined as a *-to-many relation in the Noark 5 standard

Where do you see this? In the XSD and appendix B section B.1.13, B.3.2.6 and B.3.3.6 of the Noark 5 standard it is listed with multiplicity 0-1, which is the same as is used in the API specification.

If it is wrong, it is wrong in Noark 5 and need to be fixed there first.

-- Happy hacking Petter Reinholdtsen

ivaylomitrev commented 1 year ago

I had only cross-referenced Metadatakatalog (attachment 1) as found here where M215 is defined as Forekomster: mange. image

I acknowledge that arkivstruktur.xsd states maxOccurs=1 (implicitly since it is not specified). I also acknowledge that Attachment 2 (Metadatakatalog objektsortert) lists the relation as 0..1.

It is a discrepancy in the standard in that case and must be fixed there one way or the other. Thank you!

petterreinholdtsen commented 1 year ago

[ivaylomitrev]

It is a discrepancy in the standard in that case and must be fixed there one way or the other. Thank you!

I had a look at it seem to have been fixed in <URL: https://github.com/arkivverket/noark5-standard/commit/5bfc68bb91a746dcf48f7e41e246baaa259a981c > the summer of 2021.

-- Happy hacking Petter Reinholdtsen