arm32x / command-block-ide

Replaces the command block GUI to allow editing multiple command blocks at once.
GNU Lesser General Public License v2.1
44 stars 18 forks source link

:globe_with_meridians: add korean support #30

Closed dytroc closed 1 year ago

dytroc commented 1 year ago

This PR introduces a Korean lang file to break the language barrier of South Korean mod users when using this mod.

However, what is the main purpose of having commandBlockIDE.narrator.editorIndex? Like how the key name suggests, I guess this language key exists for accessibility; however, I am not sure as I could not hear it with narrator enabled.

dytroc commented 1 year ago

Looks good to me. commandBlockIDE.narrator.editorIndex is used in the "name" of the editor text fields; I'll have to investigate why it isn't being said in the narration.

Thank you so much.

P.S. By the way, this mod quite received great attention from the Korean map making community after being introduced in a YouTube video. So, I hope this PR gets merged soon for my fellow Korean map-makers!