armadaproject / armada-operator

Apache License 2.0
13 stars 10 forks source link

allow combined label sources in Ingress, PrometheusRule, ServiceMonitor #261

Closed suprjinx closed 1 year ago

suprjinx commented 1 year ago

┆Issue is synchronized with this Jira Task by Unito

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05 :warning:

Comparison is base (7a199c3) 84.44% compared to head (1d858a8) 84.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #261 +/- ## ========================================== - Coverage 84.44% 84.40% -0.05% ========================================== Files 13 13 Lines 2540 2533 -7 ========================================== - Hits 2145 2138 -7 Misses 278 278 Partials 117 117 ``` | [Impacted Files](https://codecov.io/gh/armadaproject/armada-operator/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=armadaproject) | Coverage Δ | | |---|---|---| | [controllers/install/armadaserver\_controller.go](https://codecov.io/gh/armadaproject/armada-operator/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=armadaproject#diff-Y29udHJvbGxlcnMvaW5zdGFsbC9hcm1hZGFzZXJ2ZXJfY29udHJvbGxlci5nbw==) | `83.84% <100.00%> (-0.09%)` | :arrow_down: | | [controllers/install/binoculars\_controller.go](https://codecov.io/gh/armadaproject/armada-operator/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=armadaproject#diff-Y29udHJvbGxlcnMvaW5zdGFsbC9iaW5vY3VsYXJzX2NvbnRyb2xsZXIuZ28=) | `80.37% <100.00%> (-0.42%)` | :arrow_down: | | [controllers/install/common\_helpers.go](https://codecov.io/gh/armadaproject/armada-operator/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=armadaproject#diff-Y29udHJvbGxlcnMvaW5zdGFsbC9jb21tb25faGVscGVycy5nbw==) | `100.00% <100.00%> (ø)` | | | [controllers/install/executor\_controller.go](https://codecov.io/gh/armadaproject/armada-operator/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=armadaproject#diff-Y29udHJvbGxlcnMvaW5zdGFsbC9leGVjdXRvcl9jb250cm9sbGVyLmdv) | `80.00% <100.00%> (+0.05%)` | :arrow_up: | | [controllers/install/lookout\_controller.go](https://codecov.io/gh/armadaproject/armada-operator/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=armadaproject#diff-Y29udHJvbGxlcnMvaW5zdGFsbC9sb29rb3V0X2NvbnRyb2xsZXIuZ28=) | `84.83% <100.00%> (-0.03%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=armadaproject). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=armadaproject)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.