armadaproject / armada-operator

Apache License 2.0
13 stars 10 forks source link

ci: Fix "All required checks done" CI job to never be skipped #288

Closed jgiannuzzi closed 1 year ago

jgiannuzzi commented 1 year ago

The "All required checks done" CI job has been designed to be a required check, but GitHub considers it successful when it's skipped, and it gets skipped when some of the jobs it depends on fail.

This PR fixes that by always running the job and checking the results of all the jobs it depends on.

Example runs:

┆Issue is synchronized with this Jira Task by Unito

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (0387369) 84.17% compared to head (2468b84) 84.17%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #288 +/- ## ======================================= Coverage 84.17% 84.17% ======================================= Files 15 15 Lines 3437 3437 ======================================= Hits 2893 2893 Misses 381 381 Partials 163 163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.