search

armbian / configng

Next generation bash based configuration API
14 stars 11 forks source link

[Task]: Merge status and disabled into one functionality #117

Open igorpecovnik opened 2 days ago

igorpecovnik commented 2 days ago

Task description

JSON has status and disabled ( to not show in the menu), but this can be done via "staus". @viraniac

viraniac commented 2 days ago

I don't know what status is for, but I don't think it was ever used for hiding menu entries. I thought its for documentation purpose only.

Previously there was a field called show that was being used everywhere to show and hide menu items. Once I got conditions working, there was no need to set show as true in every json entry and hence I removed it. There is no need for disabled either, the only reason its there is because configng has dummy entries like this. Once such entries are removed, disabled can be removed as well. I had no clue if those entries were serving any purpose or not, so I left them alone

Probably @Tearran can comment better as he was involved from the start

Tearran commented 2 days ago

although extends the purpose does seem to fit well. "status": "disabled"