Closed shlomodaari closed 5 months ago
PR title: Update README.md to trigger the deploy
does not meet Armory Engineering best practices around conventional commits.
Reason: The category was missing. EX: category: description or category(scope): description. Common Categories: build, ci, chore, docs, feat, fix, perf, refactor, revert, style, test, ops
Because we enforce conventional commits and squash merges of PRs, the PR Title becomes the commit title.
<type>[optional scope]: <description> <- The PR title becomes this part.
[optional body] <- You can add this when you merge your PR.
[optional footer] <- You can add this when you merge your PR.
For more information, see the Conventional Commits specification.
Some common examples are:
docs: correct spelling of CHANGELOG
chore!: drop Node 6 from testing matrix
chore(ops)!: drop Node 6 from testing matrix
feat(armory.io): add docs.armory.io
fix(parser): grammar and spelling
style(loadingPage): made it super pretty!
refactor(helpMessages): changed order to make more sense
Resolves GitHub issue:
Resolves Jira: [JIRAPROJECT-123]