search

arnav-t / riot-embedded

Embedded version of Riot
62 stars 19 forks source link

Make this a reusable React component? #28

Open bnjbvr opened 3 years ago

bnjbvr commented 3 years ago

Hi! Thanks for working on this, it's a fantastic project! Would it make sense to make this easily reusable and export it on npm as react-riot-embed or something like this? It would be quite pleasant to be able to use it this way within another React app, and from what I've observed, not much work might be needed (but I'm speaking as one who just skimmed a few files, so I might be absurdly wrong!).

arnav-t commented 3 years ago

Hi, @bnjbvr thanks for the feedback! 😀 Making this into an embeddable react component is indeed on the agenda next. Will get to it whenever I find the time.

nzetsu commented 3 years ago

Hi! @arnav-t, thank you for the inspiration and the motivation to do more with the cool stuffs matrix.org offers to us. When do you plan to continue to work on it?

@bnjbvr, The idea sounds so good! After rewritten a project website with react.js i noticed how fun it was and want to do a bit more with it. For ex. embedding the react component will be much fun to do and also usefull, since the project is for students in my uni. Cool you please elaborate a bit more what you plan to do or give some points so that i could start something and propose it?

Please notice, that i am actually not a cs student or has studied something in the field. I am just generally interested in building stuffs and for that i always have to learn new cool thecs.

bnjbvr commented 3 years ago

@DiNaLo45 I don't plan to work on this myself, but I think one way to start would be to make the Client component public, and expose it from an index.jsx file; then make sure that nothing breaks when the component is instantiated. Then, reworking the lib to make styles customizable would surely be nice! (And I'd expect that the Matrix protocol has changed, so I'm not even sure if it would still work as is!)

Good luck, please keep us all up to date :)