search

arnoson / kirby-vite

Use Kirby CMS together with Vite
MIT License
80 stars 7 forks source link

get rid of unnecessary root parameter #21

Closed michnhokn closed 1 year ago

michnhokn commented 1 year ago

This prevents the dev mode from working because kirby()->root('base') returns null.

arnoson commented 1 year ago

It's only unnecessary if you don't define it ;) Having and extra base root that is not the same as the index root can be very useful in public folder setups (see the two kirby vite starter kits). But I agree that this should only be optional. I changed this a week ago but didn't publish it yet, will create a new release soon!

arnoson commented 1 year ago

Published the changes in v3.0.7, let me know if everything works as expected