fix: add mandatory offset

arobson / rabbot

Deprecated: Please see https://github.com/Foo-Foo-MQ/foo-foo-mq

MIT License

276 stars 129 forks source link

fix: add mandatory offset #145

Closed BridgeAR closed 4 years ago

BridgeAR commented 6 years ago

In Node.js 10.x passing in the offset is mandatory. This makes sure everything continues to work as it should.

Refs: https://github.com/nodejs/node/pull/18395

coveralls commented 6 years ago

Coverage remained the same at 88.956% when pulling 907c81f8acfdc82ccfc0cff3e4812132932a63a8 on BridgeAR:master into 80b63c08bdb32d04fd36502f24180e0c8e8f69ee on arobson:master.

BridgeAR commented 6 years ago

Ping @arobson

BridgeAR commented 6 years ago

Ping @arobson again

BridgeAR commented 6 years ago

PTAL