search

arogozhnikov / einops

Flexible and powerful tensor operations for readable and reliable code (for pytorch, jax, TF and others)
https://einops.rocks
MIT License
8.55k stars 352 forks source link

Fix tensor concat in tinygrad backend #327

Closed pzread closed 2 months ago

pzread commented 2 months ago

Pass tensors to Tensor.cat by *args instead of a list in tinygrad backend

The Tensor.cat in tinygrad backend takes tensors from *args instead of a list of tensor (https://github.com/tinygrad/tinygrad/blob/774bf39f85685aa55196b2716fa27f36d0dc88ba/tinygrad/tensor.py#L1091)

pzread commented 2 months ago

Checked the CI log https://github.com/arogozhnikov/einops/actions/runs/10849017808/job/30107331863?pr=327. The format errors seem to be unrelated to the changes of this PR

arogozhnikov commented 2 months ago

Hi Jerry, thanks for fixing!

CI errors were because new ruff version wants to format notebooks too. I've fixed those and incorporated you PR in #329