search

aromajoin / material-showcase-ios

✨ An elegant way to guide your beloved users in iOS apps - Material Showcase.
https://aromajoin.com/
Other
363 stars 128 forks source link

TapThrough Functionality for TabBarController #118

Open acali18 opened 5 years ago

acali18 commented 5 years ago

I am having a problem with the tapThrough functionality of the tabBar. Allowing tapThrough on a tabBar creates the following error: "Directly modifying a tab bar managed by a tab bar controller is not allowed'

Here is the code I've used in the past to select a tabBar index: self.tabBarController?.selectedIndex = 2

But here is the code in the MaterialShowcase.swift: onTapThrough = { tabBar.selectedItem = tabBar.items?[itemIndex] }

I believe I need to pass the tabBarController and will need a new constructor to do so as discussed here: https://github.com/aromajoin/material-showcase-ios/pull/112#issuecomment-551445883

petrkahanek commented 4 years ago

Hello,

any news to this? Checked #112 and seems that it is not fixed yet. Or would you recommend any workaround?

imSarfaroz commented 2 years ago

Any updates?

Husseinhj commented 2 years ago

Any updates? @imSarfaroz

Created #158 pull request to support TabBarViewController.

petrkahanek commented 2 years ago

Hey there, did not updated the code base so can’t really tell. Not sure if will update any time soon as I went with different solution which is sufficient for now.

S pozdravem / Best Regards Petr Kahánek

On August 1, 2022, "dependabot[bot]" @.***> wrote:

Any updates?

— Reply to this email directly, view it on GitHub https://github.com/aromajoin/material-showcase- ios/issues/118#issuecomment-1200759700, or unsubscribe https://github.com/notifications/unsubscribe- auth/AO3IG6E6XFTYAAKLY7RARSDVW5TXXANCNFSM4JKUPSSQ. You are receiving this because you commented.Message ID: @.***>