search

arran4 / golang-ical

A ICS / ICal parser and serialiser for Golang.
Apache License 2.0
311 stars 73 forks source link

Pull 66 add todo journal #84

Closed arran4 closed 10 months ago

arran4 commented 10 months ago

Hi @spslater Sorry about the mistake on https://github.com/arran4/golang-ical/pull/66 when merging in current updates. I have attempted to fix it here. Can you please review to see if I introduced any issues?

arran4 commented 10 months ago

image

Well that doesn't sound good.

arran4 commented 10 months ago

Lint saved the day.. Gaps in testing by the looks of it.

spslater commented 10 months ago

I'm reading thru it now to make sure everything looks good and catch any new functions that wouldn't have been originally changed.

arran4 commented 10 months ago

@spslater Thanks. There were a couple of relocations which made the merge a bit harder. If I had more time to work on this there is a lot I would like to improve.

spslater commented 10 months ago

For sure, I should've really split it into 3 pull requests to make reviewing it a lot easier. I'll go in and do the official review. Later I will open a new pull request for any newer functions / ones that I missed. It'll be easier to catch them and make those changes that way. But everything I originally changed looks good.

arran4 commented 10 months ago

@spslater Will review when they come through. I will wait until all your PRs are though before tagging.