search

arrayexpress / magetabcheck

1 stars 0 forks source link

Array data node check #20

Open emma-ebi opened 11 years ago

emma-ebi commented 11 years ago

For the following check:

An array data node should be described by a protocol

Can you indicate the node i.e Scan Name, Array Data File Name so people know exactly what column to look at.

olgamelnichuk commented 11 years ago

The warning, shown as result of this check, already has coordinates (line, column, sdrf file name) of array data node that was checked. We can additionally show the full node name, but may be we should do this for the all checks, not only for "array data node" one, what do you think?

emma-ebi commented 11 years ago

I think for a general submitter array data node has no real meaning so we should make it as easy as possible for them to understand and correct any errors/warning. Things like protocol node, sample node, labeled extract node make sense but array data node is a little more abstract. Thus I think this one should be changed. For the moment I think we can leave the rest.

olgamelnichuk commented 11 years ago

Ah, It seems I got it. Name of an array data file node is the file name; name of a scan node is the scan name. Therefore, showing it in the error/warning can help to localize the problem. Am I right?

emma-ebi commented 11 years ago

Yes this is right.