arrayfire-community / arrayfire_opencv

Miscellaneous ArrayFire-OpenCV interoperability functions
BSD 3-Clause "New" or "Revised" License
4 stars 6 forks source link

compatibility for current ArrayFire and current OpenCV #2

Closed meetnick closed 5 years ago

meetnick commented 5 years ago

With the respect of its creator developer, I send this pull request in order to make this compatible with current versions of ArrayFire and OpenCV (tested on 3.7.0 and 3.4.3, respectively). This pull request includes the following in order to accomplish:

It also solves issue #1

System environment: *buntu 18.04.1 LTS OpenCV 3.4.3 ArrayFire v3.7.0 (CPU|OpenCL, 64-bit Linux, build ef5183d7)

mcclanahoochie commented 5 years ago

niccolatorres thanks for the update!!

meetnick commented 5 years ago

first off, i really appreciate the update!!!

i'd prefer to keep the af:: namespace around, since you didn't remove af:: from af::exception.. so, completely remove af:: everywhere because of the 'using namespace af' , or revert the "af::" changes. thanks again!

I much appreciate to contribute to this project. I indeed agree af:: and even cv:: namespaces should be used explicitly inside to avoid namespace undesirable propagation. I removed af:: from data types because compiler was raising "af:: has no member u8/f64/s32/etc.." Now I fixed it to the correct namespace for data types, which is af::dtype::

Please consider the new commit with these changes requested.