artefactual-sdps / enduro

A tool to support ingest and automation in digital preservation workflows
https://enduro.readthedocs.io/
Apache License 2.0
4 stars 3 forks source link

Problem: usage of `key` and `secret` for bucket configuration is ambiguous #1017

Open jraddaoui opened 2 months ago

jraddaoui commented 2 months ago

Is your feature request related to a problem? Please describe.

There are a few places where we set up bucket configuration:

Also in the location configuration stored as JSON in the storage database.

We use "key" and "secret" to configure the credentials, while AWS calls them "Access Key ID" and "Secret Access Key" and MinIO uses "access key" and "secret key".

Describe the solution you'd like

It looks like @sevein already noticed this issue in the https://github.com/artefactual-labs/gotools repository, where we are using AccessKey and SecretKey in the config struct.

https://pkg.go.dev/go.artefactual.dev/tools@v0.16.0/bucket

I'd like to follow that pattern wherever possible.

Additional context