search

artefactual-sdps / enduro

A tool to support ingest and automation in digital preservation workflows
https://enduro.readthedocs.io/
Apache License 2.0
4 stars 3 forks source link

Copy premis.xsd into enduro image #1064

Closed jraddaoui closed 2 weeks ago

jraddaoui commented 2 weeks ago

This file should only be needed by the AM and a3m workers to do PREMIS validation when it's enabled. However, config validation is the same for all commands and, when PREMIS validation is enabled, it checks the existence of the XSD file in the filesystem. We tried to disable PREMIS validation only in the enduro container, but that config value is read in the workflow context, disabling the scheduling of the activity from the workflow worker.

Refs #951.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.66%. Comparing base (a8191df) to head (72ffd6d). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1064 +/- ## ========================================== - Coverage 54.74% 54.66% -0.08% ========================================== Files 104 104 Lines 7632 7632 ========================================== - Hits 4178 4172 -6 - Misses 3198 3202 +4 - Partials 256 258 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jraddaoui commented 2 weeks ago

We should try to find a better solution to how we deal with the single configuration for multiple commands in distributed environments, but this makes PREMIS validation work for now in the dev environment. Other deployments are running everything together, so it shouldn't be an issue there.