artefactual-sdps / enduro

A tool to support ingest and automation in digital preservation workflows
https://enduro.readthedocs.io/
Apache License 2.0
4 stars 3 forks source link

Revert "Run Dashboard container as non-root user" #942

Closed sbreker closed 4 months ago

sbreker commented 4 months ago

This reverts commit a9d53698493df45c1f5b0daf4050484c32d05d65.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.40%. Comparing base (eab4154) to head (5be95b0). Report is 43 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #942 +/- ## ======================================= Coverage 50.40% 50.40% ======================================= Files 102 102 Lines 5619 5619 ======================================= Hits 2832 2832 Misses 2548 2548 Partials 239 239 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

djjuhasz commented 4 months ago

@sbreker there is a nginx "unprivileged" docker image we could use instead of the default "nginx:alpine" image: https://hub.docker.com/r/nginxinc/nginx-unprivileged

Alternatively the default nginx docker image can be run as non-root with some config changes: https://hub.docker.com/_/nginx "Running nginx as a non-root user"