search

artemanufrij / playmymusic

An elementary OS app
http://anufrij.org/melody
95 stars 26 forks source link

Pause With Space Bar #126

Closed ghost closed 5 years ago

ghost commented 5 years ago

This is available in most players and is useful to those who are used to it.

artemanufrij commented 5 years ago

@infosisio could you test current master branch please?

ghost commented 5 years ago

@artemanufrij I just tested it. It works but while it is paused the progress bar resets/goes to start, then if you resume it continues from where it was.

artemanufrij commented 5 years ago

thank you for testing. I will fix it...

artemanufrij commented 5 years ago

@infosisio could you test it again, please?

Maccer1 commented 5 years ago

Not OP but I've tested it. Play/Pause with spacebar works, but if you mouseclick to pause and then use the spacebar to play it gets stuck (plays for a second and pauses again). The same happens if you click to play and then try to pause with the spacebar.

I've also found that clicking Next and then pressing spacebar it simulates a second Next click while also doing the thing I've mentioned above. The same happens with the "Previous song" button.

ghost commented 5 years ago

@artemanufrij Just tested it, works !

@Maccer1 Good observations.

artemanufrij commented 5 years ago

@Maccer1 @infosisio guys, check current master branch please.

PS: if you click to title bar (song name) it jumps directly to playing song

Maccer1 commented 5 years ago

I've updated Melody but the same issues I mentioned earlier still happen. Moreover if I click the song name it doesn't jump to it. If I double click then the window resizes but nothing more. I'm nearly sure I've updated it correctly since another bug I've reported has just been solved so I don't know what's happening :/

Also maybe I should mention that I'm using Juno beta so maybe some things could differ if you are using Loki.

artemanufrij commented 5 years ago

@Maccer1 I can't reproduce it. Could you describe it step by step?

artemanufrij commented 5 years ago

@Maccer1 I have it.

artemanufrij commented 5 years ago

can be tested

Maccer1 commented 5 years ago

I made a video if you need more clarification, but yeah it still happens (as of 15 min ago)

artemanufrij commented 5 years ago

@Maccer1 yes, please! but with last master branch...

Maccer1 commented 5 years ago

Alright. Now it's partially solved. The only issue that persists is clicking pause/play and then using the spacebar to do the same. It continues to stop the song after 1 second.

Playing another song solves this issue (until the next time you click pause/play).

artemanufrij commented 5 years ago

@Maccer1 now it should be fixed.

Maccer1 commented 5 years ago

Yes! It's perfect now :1st_place_medal:

artemanufrij commented 5 years ago

thanks for testing!