search

artemsen / swayimg

Image viewer for Wayland
MIT License
380 stars 31 forks source link

BUG: Segmentation fault when trying to open an incompatible file #31

Closed Zeioth closed 2 years ago

Zeioth commented 2 years ago

Let's say I run 

swayimg ./*

Because I want to be able to go though all my photos. If there's any incompatible file format in that directory, it will produce a core dump when trying to read it.

Solution: Allow to read only compatible file formats.

artemsen commented 2 years ago

Which version do use? I think it was fixed in 98dfcbacc856510fbd41cbd5a031abc2aa92d5ab.

P.S. You don't need to use ./* in your scenario. If input files are not specified, swayimg will show all images from the current directory.

Zeioth commented 2 years ago

That's great @artemsen !! I tested swayimg-git and the bug is solved.

About ./*

It would be great to be able to do the same thing, not only from terminal, but also from a file explorer. EXAMPLE: I open one specific file, but I can also navigate to the next one in the same directory by pressing AvPag/RePag.

Opening a file in screenshot_2022-07-27_17-00-21_567674403

artemsen commented 2 years ago

Ok, I will think about the navigation feature =)

artemsen commented 2 years ago

It would be great to be able to do the same thing, not only from terminal, but also from a file explorer.

Supported for now, just add option --all