search

artesaos / seotools

SEO Tools for Laravel
MIT License
3.04k stars 503 forks source link

OpenGraph::addProperty on array omits "og" in property name #246

Open schrink opened 3 years ago

schrink commented 3 years ago

What steps will reproduce the problem?

OpenGraph::addProperty('locale:alternate', ['en_GB', 'el_EL']);

What is the expected result?

<meta property="og:locale:alternate" content="en_GB" />
<meta property="og:locale:alternate" content="el_EL" />

What do you get instead?

<meta property=":locale:alternate" content="en_GB" />
<meta property=":locale:alternate" content="el_EL" />

Additional info

Q A
This Package Version 0.20.0
Laravel Framework Version 8.34.0
PHP version 8.03
Operating system MacOs
J-Brk commented 2 years ago

Issue confirmed. The problem occurs when using an array. As temporary workaround I suggest to try to call addProperty with single values only until a fix has been submitted / released.

J-Brk commented 1 year ago

It seems the bug has been introduced by the fix for issue: https://github.com/artesaos/seotools/issues/74.

sergiq commented 10 months ago

does somebody know if there is a due date for this issue?