artisan-roaster-scope / artisan

artisan: visual scope for coffee roasters
https://artisan-scope.org
GNU General Public License v3.0
948 stars 257 forks source link

Error on changing some MODBUS PID settings #1700

Closed beanoccio closed 2 months ago

beanoccio commented 2 months ago

Problem Description

There is an error when I change some PID settings

An unhandled exception occurred. Please report the problem on Github: https://github.com/artisan-roaster-scope/artisan/issues  When reporting this issue, please include your settings file (export  via menu Help >> Save Settings) and the details below.  An entry has been written to the error log (menu Help >> Error).  Version: 3.0.3, revision: 50dc3b3 2024-09-25, 19:54:15 -------------------------------------------------------------------------------- : invalid literal for int() with base 10: '' (line: 22826)

Steps To Reproduce

No response

Artisan Version

3.0.3 Continuous Build

Computer OS and Version

No response

Connected devices or roasting machine

No response

Files

MAKOMO commented 2 months ago

Could you be more specific which settings your changed how such that we have some clear instructions on how to reproduce this? THANKS!

beanoccio commented 2 months ago

image If you change the PID settings registers and try to save them, you will receive an error message and the changes will not be saved.

MAKOMO commented 2 months ago

Thanks for your report. We could duplicate the issue by leaving fields empty where numbers are expected. Commit 6a5ccefb78b186bc9ae0f060089454fac5f6efb3 should make the data input more robust.

Does the current Continuous Build fixes this for you? Could you please test?

Thanks!

beanoccio commented 2 months ago

That's right. If you make the changes one by one using the Tab key, the changes and saving will work.

MAKOMO commented 2 months ago

So is this issue now fixed in the new Continuous Build or not?

beanoccio commented 2 months ago

The new build is 45 minutes old. I will try it tomorrow

beanoccio commented 2 months ago

the current build is ok.

beanoccio commented 2 months ago

Thanks!

MAKOMO commented 2 months ago

Thanks for testing and this confirmation!