search

artisan-roaster-scope / artisan

artisan: visual scope for coffee roasters
https://artisan-scope.org
GNU General Public License v3.0
948 stars 257 forks source link

Multiple Event #1725

Closed Robjones6146 closed 1 month ago

Robjones6146 commented 1 month ago

Problem Description

Multiple Event does not work for Artisan Commands. According to the literature is is supposed to unless I have misunderstood.

Note that command actions can be sequenced by using a semicolon in-between single commands. Eg. the sequence pidmode(0); pidSV(180); PIDon; sleep(300); PIDoff is valid and configures the PID to manual mode with target temperature 180C and turns it on for 5 minutes. Note further that sequences of different action types can be combined using a Multiple Event event action that triggers (hidden) button actions, each grouping a list of potential different action type.

To reproduce: Multiple Event [ 11, sleep(3), 60, popup(Test Message One, 3), message(test message) ] >> 11 is activated, then nothing. This works: Multiple Event [ sleep(5), 11 ] >> Sleeps for 5 seconds then 11 is activated 11 is a button (move slider to 65%) 60 is a button (move slider to 0%)

Not sure if this is a bug or never was a feature or I am doing something wrong, sleep() works, I assumed the other should work too.

message() and popup() are very useful during multi events to show completion of each step and delay until the next step.

Steps To Reproduce

No response

Artisan Version

3.0.2

Computer OS and Version

Windows 10

Connected devices or roasting machine

Lots of Phidgets

Files

MAKOMO commented 1 month ago

Could you please attach a screen shot showing the details of your configuration, or even better, attach your Artisan settings as .aset.txt file?

Your example uses syntax which is not valid and it is unclear where you put that string exactly. THANKS!

MAKOMO commented 1 month ago

Note that the description of Multiple Event Actions only allow for comma separated numbers and sleep commands. You cannot put there other Artisan commands like popup or message. A work around is to put those in extra hidden buttons and refer to them by button number.

Robjones6146 commented 1 month ago

Exact copy of Multiple Event: 11, mesage(test message), popup(Test Message two, 3), sleep(3), 60, popup(Test Message two, 3)

On Wed, 23 Oct 2024 at 08:21, Marko Luther @.***> wrote:

Could you please attach a screen shot showing the details of your configuration, or even better, attach your Artisan settings as .aset.txt file?

Your example uses syntax which is not valid and it is unclear where you put that string exactly. THANKS!

— Reply to this email directly, view it on GitHub https://github.com/artisan-roaster-scope/artisan/issues/1725#issuecomment-2431012956, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBEHJB7BBQ6TEWBNNSSMUOTZ44567AVCNFSM6AAAAABQN7AAP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZRGAYTEOJVGY . You are receiving this because you authored the thread.Message ID: @.***>

Robjones6146 commented 1 month ago

Ok, thanks, is there a reason for that?

Robjones6146 commented 1 month ago

popup

MAKOMO commented 1 month ago

Yes. You can only use comma separated numbers and the sleep() statement within a Multiple Event command.

Robjones6146 commented 1 month ago

.... and NO spaces between commas!

On Wed, 23 Oct 2024 at 10:31, Marko Luther @.***> wrote:

Yes. You can only use comma separated numbers and the sleep() statement within a Multiple Event command.

— Reply to this email directly, view it on GitHub https://github.com/artisan-roaster-scope/artisan/issues/1725#issuecomment-2431299092, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBEHJB6K27WRL4QESYXOOXLZ45NEPAVCNFSM6AAAAABQN7AAP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZRGI4TSMBZGI . You are receiving this because you authored the thread.Message ID: @.***>

Robjones6146 commented 1 month ago

Thank you for prompt reply and assistance. Much appreciated.