search

artprima / prometheus-metrics-bundle

Symfony 5/6 Prometheus Metrics Bundle
MIT License
127 stars 29 forks source link

Add symfony 6.4 to GitHub workflow #93

Closed rmbl closed 9 months ago

denisvmedia commented 9 months ago

I merged your first PR @rmbl and this one has now conflicts. Could you please resolve them so that I could merge the PR?

P.S. Thanks for your efforts!

rmbl commented 9 months ago

Yeah, that was expected. Done :)

Will try to upgrade to 7.0 now

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7106dd9) 81.67331% compared to head (28d7003) 81.67331%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #93 +/- ## =============================================== Coverage 81.67331% 81.67331% Complexity 137 137 =============================================== Files 19 19 Lines 502 502 =============================================== Hits 410 410 Misses 92 92 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rmbl commented 9 months ago

I removed the annotations as they are no longer supported with Symfony 6.4. To keep it compatible with older Symfony versions I used the yaml configuration. Should work the same way with less dependencies.

denisvmedia commented 9 months ago

Thank you so much @rmbl 👍