search

artsy / emission

⚠️ Deprecated repo, moved to artsy/eigen ➡️ React Native Components
http://artsy.github.io/blog/2018/04/17/making-a-components-pod/
MIT License
618 stars 78 forks source link

[WIP] Collections filter modal #2067

Closed ashfurrow closed 4 years ago

ashfurrow commented 4 years ago

Worked on in Knowledge Share.

The initial modal overlay for the filter artworks component.

https://artsyproduct.atlassian.net/browse/FX-1765

ArtsyOpenSource commented 4 years ago
Fails
:no_entry_sign: 🃏 FAIL in ArtworkActions-tests.tsx
  • renders buttons correctly
    Expected: 3, received: 4
    Full message 
    
Error: expect(received).toEqual(expected) // deep equality

Expected: 3
Received: 4
    at Object.toEqual (/home/travis/build/artsy/emission/src/lib/Scenes/Artwork/Components/__tests__/ArtworkActions-tests.tsx:60:43)
    at Object.asyncJestTest (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at /home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:43:12
    at new Promise ()
    at mapper (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at /home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:73:41
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at runNextTicks (internal/process/task_queues.js:62:3)
    at processImmediate (internal/timers.js:412:9)

  • does not show the View in Room option if the artwork is not hangable
    Expected: 2, received: 3
    Full message 
    
Error: expect(received).toEqual(expected) // deep equality

Expected: 2
Received: 3
    at Object.toEqual (/home/travis/build/artsy/emission/src/lib/Scenes/Artwork/Components/__tests__/ArtworkActions-tests.tsx:93:43)
    at Object.asyncJestTest (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at /home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:43:12
    at new Promise ()
    at mapper (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at /home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:73:41
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at runNextTicks (internal/process/task_queues.js:62:3)
    at processImmediate (internal/timers.js:412:9)

  • shows a bell icon and 'Watch lot' text instead of herart icon and 'Save' if work is in an open auction
    Expected: 3, received: 4
    Full message 
    
Error: expect(received).toEqual(expected) // deep equality

Expected: 3
Received: 4
    at Object.toEqual (/home/travis/build/artsy/emission/src/lib/Scenes/Artwork/Components/__tests__/ArtworkActions-tests.tsx:122:41)
    at Object.asyncJestTest (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at /home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:43:12
    at new Promise ()
    at mapper (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at /home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:73:41
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at runNextTicks (internal/process/task_queues.js:62:3)
    at processImmediate (internal/timers.js:412:9)

  • does not show the View in Room option if the phone does not have AREnabled
    Expected: 2, received: 3
    Full message 
    
Error: expect(received).toEqual(expected) // deep equality

Expected: 2
Received: 3
    at Object.toEqual (/home/travis/build/artsy/emission/src/lib/Scenes/Artwork/Components/__tests__/ArtworkActions-tests.tsx:142:43)
    at Object.asyncJestTest (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at /home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:43:12
    at new Promise ()
    at mapper (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at /home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:73:41
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at runNextTicks (internal/process/task_queues.js:62:3)
    at processImmediate (internal/timers.js:412:9)

  • correctly displays when the work is already saved, and allows unsaving
    Snapshot name: `ArtworkActions Saving an artwork correctly displays when the work is already saved, and allows unsaving 1`- Snapshot+ Received- "Saved"+ "Hello, modal!"
    Full message 
    
Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `ArtworkActions Saving an artwork correctly displays when the work is already saved, and allows unsaving 1`

- Snapshot
+ Received

- "Saved"
+ "Hello, modal!"
    at toMatchInlineSnapshot (/home/travis/build/artsy/emission/src/lib/Scenes/Artwork/Components/__tests__/ArtworkActions-tests.tsx:197:33)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at Generator.invoke [as _invoke] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:271:22)
    at Generator.prototype. [as next] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:97:21)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at invoke (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:135:20)
    at /home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:145:13
    at /home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/modules/es.promise.js:113:22
    at flush (/home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/internals/microtask.js:26:9)
    at processTicksAndRejections (internal/process/task_queues.js:75:11)
Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `ArtworkActions Saving an artwork correctly displays when the work is already saved, and allows unsaving 2`

- Snapshot
+ Received

- "#6E1EFF"
+ undefined
    at toMatchInlineSnapshot (/home/travis/build/artsy/emission/src/lib/Scenes/Artwork/Components/__tests__/ArtworkActions-tests.tsx:198:40)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at Generator.invoke [as _invoke] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:271:22)
    at Generator.prototype. [as next] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:97:21)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at invoke (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:135:20)
    at /home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:145:13
    at /home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/modules/es.promise.js:113:22
    at flush (/home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/internals/microtask.js:26:9)
    at processTicksAndRejections (internal/process/task_queues.js:75:11)
Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `ArtworkActions Saving an artwork correctly displays when the work is already saved, and allows unsaving 3`

- Snapshot
+ Received

- "Save"
+ "Hello, modal!"
    at toMatchInlineSnapshot (/home/travis/build/artsy/emission/src/lib/Scenes/Artwork/Components/__tests__/ArtworkActions-tests.tsx:210:40)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at Generator.invoke [as _invoke] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:271:22)
    at Generator.prototype. [as next] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:97:21)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at invoke (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:135:20)
    at /home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:145:13
    at /home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/modules/es.promise.js:113:22
    at flush (/home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/internals/microtask.js:26:9)
    at processTicksAndRejections (internal/process/task_queues.js:75:11)
    at runNextTicks (internal/process/task_queues.js:62:3)
    at listOnTimeout (internal/timers.js:501:9)
    at processTimers (internal/timers.js:475:7)
Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `ArtworkActions Saving an artwork correctly displays when the work is already saved, and allows unsaving 4`

- Snapshot
+ Received

- "#000"
+ undefined
    at toMatchInlineSnapshot (/home/travis/build/artsy/emission/src/lib/Scenes/Artwork/Components/__tests__/ArtworkActions-tests.tsx:211:47)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at Generator.invoke [as _invoke] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:271:22)
    at Generator.prototype. [as next] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:97:21)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at invoke (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:135:20)
    at /home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:145:13
    at /home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/modules/es.promise.js:113:22
    at flush (/home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/internals/microtask.js:26:9)
    at processTicksAndRejections (internal/process/task_queues.js:75:11)
    at runNextTicks (internal/process/task_queues.js:62:3)
    at listOnTimeout (internal/timers.js:501:9)
    at processTimers (internal/timers.js:475:7)

  • correctly displays when the work is not saved, and allows saving
    Snapshot name: `ArtworkActions Saving an artwork correctly displays when the work is not saved, and allows saving 1`- Snapshot+ Received- "Save"+ "Hello, modal!"
    Full message 
    
Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `ArtworkActions Saving an artwork correctly displays when the work is not saved, and allows saving 1`

- Snapshot
+ Received

- "Save"
+ "Hello, modal!"
    at toMatchInlineSnapshot (/home/travis/build/artsy/emission/src/lib/Scenes/Artwork/Components/__tests__/ArtworkActions-tests.tsx:223:33)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at Generator.invoke [as _invoke] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:271:22)
    at Generator.prototype. [as next] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:97:21)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at invoke (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:135:20)
    at /home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:145:13
    at /home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/modules/es.promise.js:113:22
    at flush (/home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/internals/microtask.js:26:9)
    at processTicksAndRejections (internal/process/task_queues.js:75:11)
Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `ArtworkActions Saving an artwork correctly displays when the work is not saved, and allows saving 2`

- Snapshot
+ Received

- "#000"
+ undefined
    at toMatchInlineSnapshot (/home/travis/build/artsy/emission/src/lib/Scenes/Artwork/Components/__tests__/ArtworkActions-tests.tsx:224:40)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at Generator.invoke [as _invoke] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:271:22)
    at Generator.prototype. [as next] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:97:21)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at invoke (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:135:20)
    at /home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:145:13
    at /home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/modules/es.promise.js:113:22
    at flush (/home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/internals/microtask.js:26:9)
    at processTicksAndRejections (internal/process/task_queues.js:75:11)
Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `ArtworkActions Saving an artwork correctly displays when the work is not saved, and allows saving 3`

- Snapshot
+ Received

- "Saved"
+ "Hello, modal!"
    at toMatchInlineSnapshot (/home/travis/build/artsy/emission/src/lib/Scenes/Artwork/Components/__tests__/ArtworkActions-tests.tsx:236:40)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at Generator.invoke [as _invoke] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:271:22)
    at Generator.prototype. [as next] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:97:21)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at invoke (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:135:20)
    at /home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:145:13
    at /home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/modules/es.promise.js:113:22
    at flush (/home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/internals/microtask.js:26:9)
    at processTicksAndRejections (internal/process/task_queues.js:75:11)
Error: expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `ArtworkActions Saving an artwork correctly displays when the work is not saved, and allows saving 4`

- Snapshot
+ Received

- "#6E1EFF"
+ undefined
    at toMatchInlineSnapshot (/home/travis/build/artsy/emission/src/lib/Scenes/Artwork/Components/__tests__/ArtworkActions-tests.tsx:237:47)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at Generator.invoke [as _invoke] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:271:22)
    at Generator.prototype. [as next] (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:97:21)
    at tryCatch (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:45:40)
    at invoke (/home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:135:20)
    at /home/travis/build/artsy/emission/node_modules/regenerator-runtime/runtime.js:145:13
    at /home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/modules/es.promise.js:113:22
    at flush (/home/travis/build/artsy/emission/node_modules/react-tracking/node_modules/core-js/internals/microtask.js:26:9)
    at processTicksAndRejections (internal/process/task_queues.js:75:11)

    • :no_entry_sign: 🃏 FAIL in Artwork-tests.tsx
  • renders a snapshot
    Snapshot name: `Artwork renders a snapshot 1`- Snapshot+ Received@@ -243,10 +243,415 @@ }, ] } > + + + + + + Hello, modal!+ + + + + + Ok+ + + + Ok+ + + + + + Full message 
    
Error: expect(received).toMatchSnapshot()

Snapshot name: `Artwork renders a snapshot 1`

- Snapshot
+ Received

@@ -243,10 +243,415 @@
                },
              ]
            }
          >
            
+             
+               
+                 
+                 
+                   
+                     Hello, modal!
+                   
+                   
+                     
+                       
+                         
+                           Ok
+                         
+                       
+                       
+                         Ok
+                       
+                     
+                   
+                 
+               
+             
              )
    at mapper (/home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at /home/travis/build/artsy/emission/node_modules/jest-jasmine2/build/queueRunner.js:73:41

    • :no_entry_sign: Missing Test Files: - `src/lib/Components/__tests__/FilterModal-tests.tsx` If these files are supposed to not exist, please update your PR body to include "#skip_new_tests".

    Generated by :no_entry_sign: dangerJS