search

artsy / force

The Artsy.net website
https://www.artsy.net
MIT License
595 stars 152 forks source link

Client-side email address validation makes unhelpful suggestions. #771

Open alloy opened 7 years ago

alloy commented 7 years ago

From #766.

In this example, the suggestion doesn’t include a TLD and using it would still not make the field validate, so it seems like an unhelpful suggestion. We use this across the site, so improving it touches many places.

alloy commented 7 years ago

The library we use is https://github.com/mailcheck/mailcheck

kanaabe commented 7 years ago

https://github.com/artsy/force/issues/754#issuecomment-275240048

alloy commented 7 years ago

Copying @kanaabe's comment here https://github.com/mailcheck/mailcheck/issues/139

This definitely looks like the issue. A PR seems to have been up for 3 months.

Can someone npm instal from that person's branch and see if it indeed fixes the issue?

alloy commented 7 years ago

@1aurabrown We should probably install mailcheck from the git repo and, if it does indeed fix the issue for us, ask the mailcheck maintainers to do a release with that fix.

1aurabrown commented 7 years ago

I installed from the latest commit from mailcheck, which includes that PR, and nothing seems to have changed

screen shot 2017-02-13 at 4 22 27 pm

alloy commented 7 years ago

Should we switch or take ownership?