artsy / palette

Artsy's design system
https://palette-storybook.artsy.net/
MIT License
214 stars 45 forks source link

fix(dropdown): only manage focus when keyboard navigating #1364

Closed dzucconi closed 7 months ago

dzucconi commented 7 months ago

Closes DIA-409

A bit of a subtle problem: we don't want to manage focus when using a dropdown with a pointer device, only when keyboard navigating.

An illustration of the behavior this PR implements, where enabled is referring to focus isolation.

https://github.com/artsy/palette/assets/112297/ea05292e-ad73-45a2-9ec6-a99175d15259

artsyit commented 7 months ago

:rocket: PR was released in @artsy/palette-charts@37.1.3, @artsy/palette@38.1.3 :rocket: