search

artsy / team-navigator

An internal HR product for Artsy's team
https://team.artsy.net
MIT License
62 stars 19 forks source link

Add support for syncing GitHub teams to artsy teams #104

Open orta opened 6 years ago

orta commented 6 years ago

e.g. add people to a team when they are added to Artsy

orta commented 6 years ago

More context: https://artsy.slack.com/archives/C0KUYE93N/p1508951739000454

dblock commented 6 years ago

... and more importantly when they are removed from Artsy!

orta commented 6 years ago

That I don't think should happen in this sync - too many people wearing too many hats, removing people automatically will end up mostly being a pain. Would rather try address that at a proper peepops level 👍

joeyAghion commented 6 years ago

Syncing can be hard to maintain... we'd have to both remove people from teams and add them to new ones. And we'd have to remove employees altogether, but there are often good and different reasons to include individuals in the Github org and team site. Not to mention that Github team-management operations would conflict or just break in confusing ways.

I guess I would rather simplify the Github team structure if possible.

dblock commented 6 years ago

I think creating "automatic" groups is the right way to go and we could maintain a sync. Everybody else can go into other groups. The majority of permissions are group-based.

joeyAghion commented 6 years ago

I'm also in favor of a periodic audit maybe that surfaces people that don't exist in both sets. This would point out the special cases or the ones that need immediate modification.

orta commented 6 years ago

Audits are trivial with Peril ( can use team-nav's GraphQL API to grab the team data )