search

artsy / watt

Watt is a shared js/css/img asset library for Artsy Rails apps.
https://github.com/artsy/watt
MIT License
0 stars 0 forks source link

AMBER-786: Remove old styles from watt #387

Closed lilyfromseattle closed 5 days ago

lilyfromseattle commented 6 days ago

AMBER-786 Remove old styles from watt

Description This ticket is to remove the old artsy purple brand color and avant garde fonts from watt so that the components used by other apps (like volt) are less jarring when viewed with the new design system and brand style.

Screenshot 2024-07-02 at 11 56 43 AM
artsy-peril[bot] commented 5 days ago
Fails
:no_entry_sign: Hi there! :wave: We use conventional commit formatting which has not been detected in your PRs title. Refer to README#327 and [Conventional Commits](https://www.conventionalcommits.org) for PR/commit formatting guidelines.

Generated by :no_entry_sign: dangerJS against 2679d5e3a68a7f98d13de6a9a0df42470b4c81e9

lilyfromseattle commented 5 days ago

There isn't really any good way to test this before merging, but its only visual changes that can be reverted if necessary.

It might be worth to try to run at least Volt locally and point it to this branch instead of main on the Gemfile? https://github.com/artsy/volt/blob/f752bef22dccfdd53cb5be5b4315cde5f0f01e64/Gemfile#L14

Yup I did, I just copypasted the PR description from the Watt PR